| Date | Fri, 27 Mar 2020 15:38:01 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next 6/9] net: phy: add backplane kr driver support |
| |
On Thu, Mar 26, 2020 at 03:51:19PM +0200, Florinel Iordache wrote: > +static void setup_supported_linkmode(struct phy_device *bpphy) > +{ > + struct backplane_phy_info *bp_phy = bpphy->priv;
I'm not sure it is a good idea to completely take over phydev->priv like this, in what is just helper code. What if the PHY driver needs memory of its own? There are a few examples of this already in other PHY drivers. Could a KR PHY contain a temperature sensor? Could it contain statistics counters which need accumulating?
Andrew
|