Messages in this thread | | | Date | Thu, 26 Mar 2020 12:07:43 -0700 (PDT) | Subject | Re: [PATCH net-next 6/9] net: phy: add backplane kr driver support | From | David Miller <> |
| |
From: Joe Perches <joe@perches.com> Date: Thu, 26 Mar 2020 11:55:17 -0700
> On Thu, 2020-03-26 at 11:53 -0700, David Miller wrote: >> From: Florinel Iordache <florinel.iordache@nxp.com> >> Date: Thu, 26 Mar 2020 15:51:19 +0200 >> >> > +static void kr_reset_master_lane(struct kr_lane_info *krln) >> > +{ >> > + struct phy_device *bpphy = krln->bpphy; >> > + struct backplane_phy_info *bp_phy = bpphy->priv; >> > + const struct lane_io_ops *lane_ops = krln->bp_phy->bp_dev.lane_ops; >> >> Please use reverse christmas tree ordering for local variables. > > How (any why) do you suggest the first 2 entries here > should be ordered?
You have to sometimes put assignments into the code body rather than the declarations in situations like this.
| |