Messages in this thread Patch in this message | | | Date | Wed, 25 Mar 2020 12:06:01 -0000 | From | "tip-bot2 for Qais Yousef" <> | Subject | [tip: smp/core] firmware: psci: Replace cpu_up/down() with add/remove_cpu() |
| |
The following commit has been merged into the smp/core branch of tip:
Commit-ID: 20fb50295b139494754964d7d005b5a2f465ef08 Gitweb: https://git.kernel.org/tip/20fb50295b139494754964d7d005b5a2f465ef08 Author: Qais Yousef <qais.yousef@arm.com> AuthorDate: Mon, 23 Mar 2020 13:51:07 Committer: Thomas Gleixner <tglx@linutronix.de> CommitterDate: Wed, 25 Mar 2020 12:59:37 +01:00
firmware: psci: Replace cpu_up/down() with add/remove_cpu()
The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down().
See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong.
This also prepares to make cpu_up/down a private interface of the CPU subsystem.
Signed-off-by: Qais Yousef <qais.yousef@arm.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Link: https://lkml.kernel.org/r/20200323135110.30522-15-qais.yousef@arm.com
--- drivers/firmware/psci/psci_checker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c index 6a44539..873841a 100644 --- a/drivers/firmware/psci/psci_checker.c +++ b/drivers/firmware/psci/psci_checker.c @@ -84,7 +84,7 @@ static unsigned int down_and_up_cpus(const struct cpumask *cpus, /* Try to power down all CPUs in the mask. */ for_each_cpu(cpu, cpus) { - int ret = cpu_down(cpu); + int ret = remove_cpu(cpu); /* * cpu_down() checks the number of online CPUs before the TOS @@ -116,7 +116,7 @@ static unsigned int down_and_up_cpus(const struct cpumask *cpus, /* Try to power up all the CPUs that have been offlined. */ for_each_cpu(cpu, offlined_cpus) { - int ret = cpu_up(cpu); + int ret = add_cpu(cpu); if (ret != 0) { pr_err("Error occurred (%d) while trying "
| |