lkml.org 
[lkml]   [2020]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 04/17] arm: Don't use disable_nonboot_cpus()
    Date
    disable_nonboot_cpus() is not safe to use when doing machine_down(),
    because it relies on freeze_secondary_cpus() which in turn is
    a suspend/resume related freeze and could abort if the logic detects any
    pending activities that can prevent finishing the offlining process.

    Beside disable_nonboot_cpus() is dependent on CONFIG_PM_SLEEP_SMP which
    is an othogonal config to rely on to ensure this function works
    correctly.

    Signed-off-by: Qais Yousef <qais.yousef@arm.com>
    CC: Russell King <linux@armlinux.org.uk>
    CC: linux-arm-kernel@lists.infradead.org
    CC: linux-kernel@vger.kernel.org
    ---
    arch/arm/kernel/reboot.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
    index bb18ed0539f4..58ad1a70f770 100644
    --- a/arch/arm/kernel/reboot.c
    +++ b/arch/arm/kernel/reboot.c
    @@ -88,11 +88,11 @@ void soft_restart(unsigned long addr)
    * to execute e.g. a RAM-based pin loop is not sufficient. This allows the
    * kexec'd kernel to use any and all RAM as it sees fit, without having to
    * avoid any code or data used by any SW CPU pin loop. The CPU hotplug
    - * functionality embodied in disable_nonboot_cpus() to achieve this.
    + * functionality embodied in smp_shutdown_nonboot_cpus() to achieve this.
    */
    void machine_shutdown(void)
    {
    - disable_nonboot_cpus();
    + smp_shutdown_nonboot_cpus(0);
    }

    /*
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-03-23 14:54    [W:3.312 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site