Messages in this thread | | | Date | Tue, 24 Mar 2020 19:07:09 +0100 | From | Alexandre Belloni <> | Subject | Re: [PATCH v2 1/6] dt-bindings: rtc: Convert snps,dw-apb-timer to DT schema |
| |
Hi,
On 24/03/2020 20:43:20+0300, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Modern device tree bindings are supposed to be created as YAML-files > in accordance with DT schema. This commit replaces Synopsys DW Timer > legacy bare text binding with YAML file. As before the binding file > states that the corresponding dts node is supposed to be compatible > with generic DW APB Timer indicated by the "snps,dw-apb-timer" > compatible string and to provide a mandatory registers memory range, > one timer interrupt, either reference clock source or a fixed clock > rate value. It may also have an optional APB bus reference clock > phandle specified. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Paul Burton <paulburton@kernel.org> > Cc: Ralf Baechle <ralf@linux-mips.org> > Cc: Alessandro Zummo <a.zummo@towertech.it> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: devicetree@vger.kernel.org > Cc: linux-rtc@vger.kernel.org > > --- > > I have doubts that this binding file belongs to the bindings/rtc > directory seeing it's a pure timer with no rtc facilities like > days/months/years counting and alarms. What about moving it to the > "Documentation/devicetree/bindings/timer/" directory? >
Exactly my reaction when seeing the patch, please move it out of bindings/rtc/
-- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |