Messages in this thread | | | Date | Mon, 2 Mar 2020 13:24:25 -0800 | From | Eric Biggers <> | Subject | Re: [PATCH v2 1/2] tty: fix compat TIOCGSERIAL leaking uninitialized memory |
| |
On Tue, Feb 25, 2020 at 08:30:35AM +0100, Jiri Slaby wrote: > On 24. 02. 20, 19:20, Eric Biggers wrote: > > From: Eric Biggers <ebiggers@google.com> > > > > Commit 77654350306a ("take compat TIOC[SG]SERIAL treatment into > > tty_compat_ioctl()") changed the compat version of TIOCGSERIAL to start > > copying a whole 'serial_struct32' to userspace rather than individual > > fields, but failed to initialize all padding and fields -- namely the > > hole after the 'iomem_reg_shift' field, and the 'reserved' field. > > > > Fix this by initializing the struct to zero. > > > > [v2: use sizeof, and convert the adjacent line for consistency.] > > > > Reported-by: syzbot+8da9175e28eadcb203ce@syzkaller.appspotmail.com > > Fixes: 77654350306a ("take compat TIOC[SG]SERIAL treatment into tty_compat_ioctl()") > > Cc: <stable@vger.kernel.org> # v4.20+ > > Signed-off-by: Eric Biggers <ebiggers@google.com> > > Acked-by: Jiri Slaby <jslaby@suse.cz> >
Thanks. Greg, are you planning to take these patches?
- Eric
| |