Messages in this thread | | | Date | Wed, 18 Mar 2020 09:36:56 -0700 | From | Eric Biggers <> | Subject | Re: [PATCH v2 1/2] tty: fix compat TIOCGSERIAL leaking uninitialized memory |
| |
On Wed, Mar 18, 2020 at 01:00:00PM +0100, Greg Kroah-Hartman wrote: > On Mon, Mar 02, 2020 at 01:24:25PM -0800, Eric Biggers wrote: > > On Tue, Feb 25, 2020 at 08:30:35AM +0100, Jiri Slaby wrote: > > > On 24. 02. 20, 19:20, Eric Biggers wrote: > > > > From: Eric Biggers <ebiggers@google.com> > > > > > > > > Commit 77654350306a ("take compat TIOC[SG]SERIAL treatment into > > > > tty_compat_ioctl()") changed the compat version of TIOCGSERIAL to start > > > > copying a whole 'serial_struct32' to userspace rather than individual > > > > fields, but failed to initialize all padding and fields -- namely the > > > > hole after the 'iomem_reg_shift' field, and the 'reserved' field. > > > > > > > > Fix this by initializing the struct to zero. > > > > > > > > [v2: use sizeof, and convert the adjacent line for consistency.] > > > > > > > > Reported-by: syzbot+8da9175e28eadcb203ce@syzkaller.appspotmail.com > > > > Fixes: 77654350306a ("take compat TIOC[SG]SERIAL treatment into tty_compat_ioctl()") > > > > Cc: <stable@vger.kernel.org> # v4.20+ > > > > Signed-off-by: Eric Biggers <ebiggers@google.com> > > > > > > Acked-by: Jiri Slaby <jslaby@suse.cz> > > > > > > > Thanks. Greg, are you planning to take these patches? > > Yes, sorry, they were not cc: linux-serial and fell through my initial > filters, to go into my generic "to-review" bucket. Will take them > now... >
If people are supposed to send tty patches to linux-serial, then you need to add it to MAINTAINERS:
$ ./scripts/get_maintainer.pl drivers/tty/ Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:TTY LAYER) Jiri Slaby <jslaby@suse.com> (supporter:TTY LAYER) linux-kernel@vger.kernel.org (open list)
| |