Messages in this thread | | | Subject | Re: [PATCH 2/3] dt-bindings: leds: Add binding for sgm3140 | From | Dan Murphy <> | Date | Wed, 11 Mar 2020 07:49:35 -0500 |
| |
Luca
On 3/9/20 3:35 PM, Luca Weiss wrote: > Add YAML devicetree binding for SGMICRO SGM3140 charge pump used for > camera flash LEDs. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > Changes since RFC: > - new patch > > I'm not sure about the completeness of this binding as it doesn't > mention the led subnode at all. > The only existing led yaml binding is leds/leds-max77650.yaml which > mentions the subnode but duplicates properties from documented in > leds/common.txt. > > .../bindings/leds/leds-sgm3140.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > new file mode 100644 > index 000000000000..be9384573d02 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-sgm3140.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SGMICRO SGM3140 500mA Buck/Boost Charge Pump LED Driver > + > +maintainers: > + - Luca Weiss <luca@z3ntu.xyz> > + > +description: | > + The SGM3140 is a current-regulated charge pump which can regulate two current > + levels for Flash and Torch modes. > + > + It is controlled with two GPIO pins. Please define "It". Not sure what is controlled here.
Dan
| |