Messages in this thread | | | Date | Mon, 9 Mar 2020 23:49:27 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 3/3] leds: add sgm3140 driver |
| |
Hi!
> > +#define FLASH_TIMEOUT_DEFAULT 250000 /* 250ms */ > > +#define FLASH_MAX_TIMEOUT_DEFAULT 300000 /* 300ms */ > > Add U, and you can remove the cast elsewhere.
I'll disagree here. Avoid U, avoid cast. Neither is needed.
Best regards, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |