Messages in this thread | | | Date | Tue, 10 Mar 2020 20:41:42 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation |
| |
On Tue, 10 Mar 2020 20:39:30 +0100 Boris Brezillon <boris.brezillon@collabora.com> wrote:
> On Tue, 3 Mar 2020 15:21:23 +0800 > Mason Yang <masonccyang@mxic.com.tw> wrote: > > > Patch nand_suspend() & nand_resume() for manufacturer specific > > suspend/resume operation. > > > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > > Reported-by: kbuild test robot <lkp@intel.com> > > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > drivers/mtd/nand/raw/nand_base.c | 11 ++++++++--- > > include/linux/mtd/rawnand.h | 4 ++++ > > 2 files changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index 769be81..b44e460 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -4327,7 +4327,9 @@ static int nand_suspend(struct mtd_info *mtd) > > struct nand_chip *chip = mtd_to_nand(mtd); > > > > mutex_lock(&chip->lock); > > - chip->suspended = 1; > > + if (chip->_suspend) > > + if (!chip->_suspend(chip)) > > + chip->suspended = 1;
Shouldn't you propagate the error to the caller if chip->_suspend() fails?
| |