lkml.org 
[lkml]   [2020]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation
From
Date

Hi Miquel,

> > > > diff --git a/include/linux/mtd/rawnand.h
b/include/linux/mtd/rawnand.h
> > > > index bc2fa3c..c0055ed 100644
> > > > --- a/include/linux/mtd/rawnand.h
> > > > +++ b/include/linux/mtd/rawnand.h
> > > > @@ -1064,6 +1064,8 @@ struct nand_legacy {
> > > > * @lock: lock protecting the suspended field. Also used to
> > > > * serialize accesses to the NAND device.
> > > > * @suspended: set to 1 when the device is suspended, 0 when

> > it's not.
> > > > + * @_suspend: [REPLACEABLE] specific NAND device suspend
> > operation
> > > > + * @_resume: [REPLACEABLE] specific NAND device resume
operation
> > > > * @bbt: [INTERN] bad block table pointer
> > > > * @bbt_td: [REPLACEABLE] bad block table descriptor for
flash
> > > > * lookup.
> > > > @@ -1119,6 +1121,8 @@ struct nand_chip {
> > > >
> > > > struct mutex lock;
> > > > unsigned int suspended : 1;
> > > > + int (*_suspend)(struct nand_chip *chip);
> > > > + void (*_resume)(struct nand_chip *chip);
> > >
> > > I thought we agreed on not prefixing new hooks with _ ?
> >
> > For [PATCH v2] series, you mentioned to drop the _ prefix
> > of _lock/_unlock only and we finally patched to lock_area/unlock_area.
> >
>
> I missed this _, this is not something we want to add.
>
> Also, when applying your patches I had several issues because they
> where not base on the last -rc1.
>
> Finally, I think I forgot a line when patching manually so it produces
> a warning now.
>
> I am dropping patch 3 and 4, I keep patch 1 and 2 which seem fine.
>
> Please send a rebased and edited v4 for these, don't forget to drop the
> kbuildtest robot tag and please also follow these slightly edited
> commit logs:
>
> 2/4
>
> mtd: rawnand: Add support for manufacturer specific suspend/resume
operation
>
> Patch nand_suspend() & nand_resume() to let manufacturers overwrite
> suspend/resume operations.
>
> 3/4
>
> mtd: rawnand: macronix: Add support for deep power down mode
>
> Macronix AD series support deep power down mode for a minimum
> power consumption state.
>
> Overlaod nand_suspend() & nand_resume() in Macronix specific code to
> support deep power down mode.

okay, will resend [PATCH v4 xx/2] for suspend/resume operation with these
commit logs.

>
> Thanks,
> Miquèl

thanks for your review & comments.
Mason


CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================

\
 
 \ /
  Last update: 2020-03-12 02:46    [W:0.052 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site