Messages in this thread | | | Subject | Re: [PATCH v12 1/2] fs: New zonefs file system | From | Markus Elfring <> | Date | Thu, 6 Feb 2020 20:56:05 +0100 |
| |
> zonefs is a very simple file system …
How do you think about to be consistent with the capitalisation at the beginning of such sentences? https://lore.kernel.org/linux-fsdevel/20200206052631.111586-1-damien.lemoal@wdc.com/
… > +++ b/fs/zonefs/super.c … > +static int zonefs_create_zgroup(struct zonefs_zone_data *zd, > + enum zonefs_ztype type) > +{ … > + if (type == ZONEFS_ZTYPE_CNV) > + zgroup_name = "cnv"; > + else > + zgroup_name = "seq";
I find the following code variant more succinct.
+ zgroup_name = (type == ZONEFS_ZTYPE_CNV) ? "cnv" : "seq";
Regards, Markus
| |