lkml.org 
[lkml]   [2020]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v12 1/2] fs: New zonefs file system
From
Date
> zonefs is a very simple file system …

How do you think about to be consistent with the capitalisation
at the beginning of such sentences?
https://lore.kernel.org/linux-fsdevel/20200206052631.111586-1-damien.lemoal@wdc.com/



> +++ b/fs/zonefs/super.c

> +static int zonefs_create_zgroup(struct zonefs_zone_data *zd,
> + enum zonefs_ztype type)
> +{

> + if (type == ZONEFS_ZTYPE_CNV)
> + zgroup_name = "cnv";
> + else
> + zgroup_name = "seq";

I find the following code variant more succinct.

+ zgroup_name = (type == ZONEFS_ZTYPE_CNV) ? "cnv" : "seq";


Regards,
Markus

\
 
 \ /
  Last update: 2020-02-06 21:02    [W:0.036 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site