Messages in this thread | | | Subject | Re: [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver | From | Sameer Pujar <> | Date | Tue, 4 Feb 2020 10:06:53 +0530 |
| |
On 1/30/2020 10:55 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 30.01.2020 13:33, Sameer Pujar пишет: > ... >> +#include <linux/clk.h> >> +#include <linux/device.h> >> +#include <linux/module.h> >> +#include <linux/of_platform.h> >> +#include <linux/platform_device.h> >> +#include <linux/pm_runtime.h> >> +#include <linux/regmap.h> >> +#include <sound/soc.h> >> +#include "tegra210_ahub.h" > Nit: I'd separate the per-directory includes with a blank line, like it > done by the most of existing drivers, for consistency.
I don't see this being followed consistently for sound drivers. I think it is good as it is, it appears compact and clean.
| |