Messages in this thread | | | Subject | Re: [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver | From | Sameer Pujar <> | Date | Fri, 31 Jan 2020 08:42:28 +0530 |
| |
On 1/30/2020 10:55 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 30.01.2020 13:33, Sameer Pujar пишет: > ... >> +#include <linux/clk.h> >> +#include <linux/device.h> >> +#include <linux/module.h> >> +#include <linux/of_platform.h> >> +#include <linux/platform_device.h> >> +#include <linux/pm_runtime.h> >> +#include <linux/regmap.h> >> +#include <sound/soc.h> >> +#include "tegra210_ahub.h" > Nit: I'd separate the per-directory includes with a blank line, like it > done by the most of existing drivers, for consistency.
Hi Dmitry,
I'd assume these are the only review comments (which includes your other replies for v2 5/9) for the series. Let me know otherwise.
It would help me to discuss all the issues at once, finalize changes for v3 and so that we can avoid multiple iterations.
Thanks, Sameer.
| |