Messages in this thread | | | From | Oded Gabbay <> | Date | Tue, 25 Feb 2020 13:56:04 +0200 | Subject | Re: [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock() |
| |
On Mon, Feb 24, 2020 at 1:18 AM Jules Irenge <jbi.octave@gmail.com> wrote: > > Sparse reports a warning at goya_hw_queues_unlock() > warning: context imbalance in goya_hw_queues_unlock() - unexpected unlock > The root cause is a missing annotation at goya_hw_queues_unlock() > Add the missing __releases(&goya->hw_queues_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> > --- > drivers/misc/habanalabs/goya/goya.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c > index 8ca7ee57cbc1..6138b461d0f8 100644 > --- a/drivers/misc/habanalabs/goya/goya.c > +++ b/drivers/misc/habanalabs/goya/goya.c > @@ -5081,6 +5081,7 @@ static void goya_hw_queues_lock(struct hl_device *hdev) > } > > static void goya_hw_queues_unlock(struct hl_device *hdev) > + __releases(&goya->hw_queues_lock) > { > struct goya_device *goya = hdev->asic_specific; > > -- > 2.24.1 > This patch is: Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com> Applied to -next Thanks, Oded
| |