Messages in this thread Patch in this message | | | From | Jules Irenge <> | Subject | [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock() | Date | Sun, 23 Feb 2020 23:17:11 +0000 |
| |
Sparse reports a warning at ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock() warning: context imbalance in ocfs2_inode_cache_lock() - wrong count at exit
warning: context imbalance in ocfs2_inode_cache_unlock() - unexpected unlock The root cause is a missing annotation at ocfs2_inode_cache_lock() and at ocfs2_inode_cache_unlock()
Add the missing __acquires(&oi->ip_lock) annotation Add the missing __releases(&oi->ip_lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- fs/ocfs2/inode.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 7c9dfd50c1c1..0b87e0a63ab9 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -1623,6 +1623,7 @@ static struct super_block *ocfs2_inode_cache_get_super(struct ocfs2_caching_info } static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci) + __acquires(&oi->ip_lock) { struct ocfs2_inode_info *oi = cache_info_to_inode(ci); @@ -1630,6 +1631,7 @@ static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci) } static void ocfs2_inode_cache_unlock(struct ocfs2_caching_info *ci) + __releases(&oi->ip_lock) { struct ocfs2_inode_info *oi = cache_info_to_inode(ci); -- 2.24.1
| |