| Date | Wed, 26 Feb 2020 01:35:51 +0100 | From | Frederic Weisbecker <> | Subject | Re: [PATCH v4 09/27] rcu: Rename rcu_irq_{enter,exit}_irqson() |
| |
On Fri, Feb 21, 2020 at 02:34:25PM +0100, Peter Zijlstra wrote: > The functions do in fact use local_irq_{save,restore}() and can > therefore be used when IRQs are in fact disabled. Worse, they are > already used in places where IRQs are disabled, leading to great > confusion when reading the code. > > Rename them to fix this confusion. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
FWIW I'd have called that _irqsafe() as irqsave() suggests some return value to later restore.
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
|