| From | Andy Lutomirski <> | Date | Fri, 21 Feb 2020 11:10:05 -0800 | Subject | Re: [PATCH v4 06/27] x86/doublefault: Remove memmove() call |
| |
On Fri, Feb 21, 2020 at 5:50 AM Peter Zijlstra <peterz@infradead.org> wrote: > > Use of memmove() in #DF is problematic when you consider tracing and > other instrumentation. > > Remove the memmove() call and simply write out what need doing; Boris > argues the ranges should not overlap. > > Survives selftests/x86, specifically sigreturn_64. > > (Andy ?!)
Acked-by: Andy Lutomirski <luto@kernel.org>
Even ignoring the tracing issue, I think this is nicer than the original code.
|