Messages in this thread | | | Date | Mon, 24 Feb 2020 13:59:11 +0000 | From | Liviu Dudau <> | Subject | Re: [PATCH] drm/arm: make hdlcd_debugfs_init return 0 |
| |
Hi,
On Tue, Feb 18, 2020 at 08:28:13PM +0300, Wambui Karuga wrote: > As drm_debugfs_create_files should return void, remove its use as a > return value in hdlcd_debugfs_init and have the latter function return 0 > directly. > > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index 2e053815b54a..bd0ad6f46a97 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -226,8 +226,10 @@ static struct drm_info_list hdlcd_debugfs_list[] = { > > static int hdlcd_debugfs_init(struct drm_minor *minor) > { > - return drm_debugfs_create_files(hdlcd_debugfs_list, > - ARRAY_SIZE(hdlcd_debugfs_list), minor->debugfs_root, minor); > + drm_debugfs_create_files(hdlcd_debugfs_list, > + ARRAY_SIZE(hdlcd_debugfs_list), > + minor->debugfs_root, minor); > + return 0; > } > #endif > > -- > 2.25.0 >
Thanks for your patch! I had to go into the ML and find out the series where this patch belongs to and seen that you have already received some feedback, but I think a summary is worth:
- you should look if it is possible to make .debugfs_init hook return void, it would simplify the cleanup in the drivers by not having to return 0. - you should put in each driver patch a note that drm_debugfs_create_files() always returns 0 since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail) so that people don't have to hunt in the git history for clues. - Make all the changes into a series
With that, you can have my Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards, Liviu
-- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
| |