Messages in this thread | | | From | Wambui Karuga <> | Date | Tue, 18 Feb 2020 21:02:56 +0300 (EAT) | Subject | Re: [PATCH] drm/etnaviv: remove check for return value of drm_debugfs function |
| |
On Tue, 18 Feb 2020, Lucas Stach wrote:
> On Di, 2020-02-18 at 20:28 +0300, Wambui Karuga wrote: >> As there is no need to check the return value if >> drm_debugfs_create_files, > > And here is where the commit message skips a very important > information: Since 987d65d01356 (drm: debugfs: make > drm_debugfs_create_files() never fail) this function never returns > anything other than 0, so there is no point in checking. This > information should be in the commit message, so the reviewer doesn't > need to look up this fact in the git history. > Okay, I can add that to the commit message and resend. Thanks.
> Regards, > Lucas > >> remove the check and error handling in >> etnaviv_debugfs_init and have the function return 0 directly. >> >> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> >> --- >> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 16 ++++------------ >> 1 file changed, 4 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c >> b/drivers/gpu/drm/etnaviv/etnaviv_drv.c >> index 6b43c1c94e8f..a65d30a48a9d 100644 >> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c >> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c >> @@ -233,19 +233,11 @@ static struct drm_info_list >> etnaviv_debugfs_list[] = { >> >> static int etnaviv_debugfs_init(struct drm_minor *minor) >> { >> - struct drm_device *dev = minor->dev; >> - int ret; >> - >> - ret = drm_debugfs_create_files(etnaviv_debugfs_list, >> - ARRAY_SIZE(etnaviv_debugfs_list), >> - minor->debugfs_root, minor); >> + drm_debugfs_create_files(etnaviv_debugfs_list, >> + ARRAY_SIZE(etnaviv_debugfs_list), >> + minor->debugfs_root, minor); >> >> - if (ret) { >> - dev_err(dev->dev, "could not install >> etnaviv_debugfs_list\n"); >> - return ret; >> - } >> - >> - return ret; >> + return 0; >> } >> #endif >> > >
| |