| Date | Tue, 18 Feb 2020 16:14:35 +1100 | From | Dave Chinner <> | Subject | Re: [PATCH v6 05/19] mm: Remove 'page_offset' from readahead loop |
| |
On Mon, Feb 17, 2020 at 10:45:48AM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" <willy@infradead.org> > > Eliminate the page_offset variable which was confusing with the > 'offset' parameter and record the start of each consecutive run of > pages in the readahead_control. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > mm/readahead.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-)
Looks ok, but having the readahead dispatch out of line from the case that triggers it makes it hard to follow.
Cheers,
Dave.
-- Dave Chinner david@fromorbit.com
|