| Date | Tue, 18 Feb 2020 15:47:30 +1100 | From | Dave Chinner <> | Subject | Re: [PATCH v6 01/19] mm: Return void from various readahead functions |
| |
On Mon, Feb 17, 2020 at 10:45:42AM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" <willy@infradead.org> > > ondemand_readahead has two callers, neither of which use the return value. > That means that both ra_submit and __do_page_cache_readahead() can return > void, and we don't need to worry that a present page in the readahead > window causes us to return a smaller nr_pages than we ought to have. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- Dave Chinner david@fromorbit.com
|