Messages in this thread Patch in this message | | | Date | Tue, 18 Feb 2020 19:05:13 +0800 | Subject | [Bluez PATCH v1] bluetooth: fix passkey uninitialized when used | From | Howard Chung <> |
| |
From: "howardchung@google.com" <howardchung@google.com>
This issue cause a warning here https://groups.google.com/forum/#!topic/clang-built-linux/kyRKCjRsGoU
Signed-off-by: Howard Chung <howardchung@google.com> ---
net/bluetooth/smp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c index 50e0ac692ec4..fa40de69e487 100644 --- a/net/bluetooth/smp.c +++ b/net/bluetooth/smp.c @@ -2179,10 +2179,12 @@ static u8 smp_cmd_pairing_random(struct l2cap_conn *conn, struct sk_buff *skb) */ if (hci_find_ltk(hcon->hdev, &hcon->dst, hcon->dst_type, hcon->role)) { + /* Set passkey to 0. The value can be any number since + * it'll be ignored anyway. + */ err = mgmt_user_confirm_request(hcon->hdev, &hcon->dst, hcon->type, - hcon->dst_type, - passkey, 1); + hcon->dst_type, 0, 1); if (err) return SMP_UNSPECIFIED; set_bit(SMP_FLAG_WAIT_USER, &smp->flags); -- 2.25.0.265.gbab2e86ba0-goog
| |