lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 040/542] RDMA/i40iw: fix a potential NULL pointer dereference
    Date
    From: Xiyu Yang <xiyuyang19@fudan.edu.cn>

    [ Upstream commit 04db1580b5e48a79e24aa51ecae0cd4b2296ec23 ]

    A NULL pointer can be returned by in_dev_get(). Thus add a corresponding
    check so that a NULL pointer dereference will be avoided at this place.

    Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status")
    Link: https://lore.kernel.org/r/1577672668-46499-1-git-send-email-xiyuyang19@fudan.edu.cn
    Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
    Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
    Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
    Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/i40iw/i40iw_main.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c
    index d44cf33df81ae..238614370927a 100644
    --- a/drivers/infiniband/hw/i40iw/i40iw_main.c
    +++ b/drivers/infiniband/hw/i40iw/i40iw_main.c
    @@ -1225,6 +1225,8 @@ static void i40iw_add_ipv4_addr(struct i40iw_device *iwdev)
    const struct in_ifaddr *ifa;

    idev = in_dev_get(dev);
    + if (!idev)
    + continue;
    in_dev_for_each_ifa_rtnl(ifa, idev) {
    i40iw_debug(&iwdev->sc_dev, I40IW_DEBUG_CM,
    "IP=%pI4, vlan_id=%d, MAC=%pM\n", &ifa->ifa_address,
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 19:22    [W:2.876 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site