lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 325/542] bnxt: Detach page from page pool before sending up the stack
    Date
    From: Jonathan Lemon <jonathan.lemon@gmail.com>

    [ Upstream commit 3071c51783b39d6a676d02a9256c3b3f87804285 ]

    When running in XDP mode, pages come from the page pool, and should
    be freed back to the same pool or specifically detached. Currently,
    when the driver re-initializes, the page pool destruction is delayed
    forever since it thinks there are oustanding pages.

    Fixes: 322b87ca55f2 ("bnxt_en: add page_pool support")
    Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
    Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    index 01b603c5e76ad..9d62200b6c335 100644
    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -944,6 +944,7 @@ static struct sk_buff *bnxt_rx_page_skb(struct bnxt *bp,
    dma_addr -= bp->rx_dma_offset;
    dma_unmap_page_attrs(&bp->pdev->dev, dma_addr, PAGE_SIZE, bp->rx_dir,
    DMA_ATTR_WEAK_ORDERING);
    + page_pool_release_page(rxr->page_pool, page);

    if (unlikely(!payload))
    payload = eth_get_headlen(bp->dev, data_ptr, len);
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 19:05    [W:6.348 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site