Messages in this thread | | | From | Qais Yousef <> | Subject | [PATCH 0/3] RT Capacity Awareness Improvements | Date | Fri, 14 Feb 2020 16:39:46 +0000 |
| |
Pavan has pointed out an oversight in the first implementation where we don't fallback to another unfitting CPU if we are already running on unfitting one.
This also stirred discussion around handling downmigration from fitting to unfitting CPU.
https://lore.kernel.org/lkml/20200203111451.0d1da58f@oasis.local.home/
Patch 1 adds the missing fallback when a fitting CPU wasn't found, reported by Pavan.
Patch 2 allows downmigration in the pull case and marks the CPU as overloaded as suggested by Steve.
Patch 3 fixes the condition in select_task_rq_rt() in case the new_cpu and the task priorities are the *same*.
The series is based on Linus/master v5.6-rc1.
I ran the following test cases, the results of which can be found in [1] Each test was run 3 times to demonstrate repeatability of the result.
The tests were ran on Juno-r2, which has 6 CPUs. CPUs [0, 3-5] are Littles and CPUs [1-2] are Bigs.
By default RT tasks are boosted to max capacity, so no work was done to modify that. ie: rt_task->uclamp_min = 1024 for all running tests.
1. 6 RT Tasks * 2 Tasks always end up on the big cores * The rest end up on the little cores with migration among them happening (it didn't before) 2. 2 RT Tasks * We can see they always end up on the 2 big cores 3. 4 RT Tasks * Results similar to 1 4. 4 RT Tasks affined to little cores * The tasks run on the little cores with some migration as expected
[1] https://gist.github.com/qais-yousef/bb99bdd912628489408a5edae33f85e1
Qais Yousef (3): sched/rt: cpupri_find: implement fallback mechanism for !fit case sched/rt: allow pulling unfitting task sched/rt: fix pushing unfit tasks to a better CPU
kernel/sched/cpupri.c | 157 +++++++++++++++++++++++++++--------------- kernel/sched/rt.c | 50 ++++++++++---- 2 files changed, 139 insertions(+), 68 deletions(-)
-- 2.17.1
| |