Messages in this thread | | | Date | Fri, 4 Dec 2020 15:43:25 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH v2 06/15] usb: misc: emi62: update to use usb_control_msg_send() |
| |
On Mon, Nov 30, 2020 at 06:59:25AM +0530, Anant Thazhemadam wrote: > The newer usb_control_msg_{send|recv}() API are an improvement on the > existing usb_control_msg() as it ensures that a short read/write is treated > as an error, data can be used off the stack, and raw usb pipes need not be > created in the calling functions. > For this reason, the instance of usb_control_msg() has been replaced with > usb_control_msg_send() appropriately. > > Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com> > ---
This driver looks like it shares origins with the emi26 one so the same comments apply (and especially not put large structures on the stack).
Johan
| |