Messages in this thread Patch in this message | | | From | YANG LI <> | Subject | [PATCH] fs: fix: second lock in function d_prune_aliases(). | Date | Wed, 30 Dec 2020 15:01:25 +0800 |
| |
Goto statement jumping will cause lock to be executed again without executing unlock, placing the lock statement in front of goto label to fix this problem.
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com> Reported-by: Abaci <abaci@linux.alibaba.com> --- fs/dcache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dcache.c b/fs/dcache.c index 97e81a8..bf38446 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1050,6 +1050,6 @@ void d_prune_aliases(struct inode *inode) { struct dentry *dentry; -restart: spin_lock(&inode->i_lock); +restart: hlist_for_each_entry(dentry, &inode->i_dentry, d_u.d_alias) { spin_lock(&dentry->d_lock); -- 1.8.3.1
| |