lkml.org 
[lkml]   [2020]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] media: smiapp: avoid printing an uninitialized variable
Date
From: Arnd Bergmann <arnd@arndb.de>

There is no intialization for the 'reg' variable, so printing
it produces undefined behavior as well as a compile-time warning:

drivers/media/i2c/ccs/ccs-core.c:314:49: error: variable 'reg' is uninitialized when used here [-Werror,-Wuninitialized]
"0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,

Remove the variable and stop printing it.

Fixes: b24cc2a18c50 ("media: smiapp: Rename as "ccs"")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/i2c/ccs/ccs-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index 69e7990c65f3..58a42459109d 100644
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -257,7 +257,6 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
u32 pixels;
char *which;
char *what;
- u32 reg;

if (fmt_model_type == CCS_FRAME_FORMAT_MODEL_TYPE_2_BYTE) {
desc = CCS_LIM_AT(sensor, FRAME_FORMAT_DESCRIPTOR, i);
@@ -311,7 +310,7 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
}

dev_dbg(&client->dev,
- "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
+ "%s pixels: %d %s (pixelcode %u)\n",
what, pixels, which, pixelcode);

if (i < ncol_desc) {
--
2.27.0
\
 
 \ /
  Last update: 2020-12-03 23:31    [W:0.038 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site