Messages in this thread | | | Subject | Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver | From | Daniel Scally <> | Date | Mon, 28 Dec 2020 23:30:56 +0000 |
| |
Hi Andy
On 28/12/2020 22:55, Andy Shevchenko wrote: > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: >> On 28/12/2020 17:05, Sakari Ailus wrote: >>> On Thu, Dec 24, 2020 at 02:54:44PM +0200, Andy Shevchenko wrote: > ... > >>>>> +#include <linux/property.h> >>>>> + >>>>> +#define CIO2_HID "INT343E" >>>>> +#define CIO2_NUM_PORTS 4 >>> This is already defined in ipu3-cio2.h. Could you include that instead? >> Yes; but I'd need to also include media/v4l2-device.h and >> media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the >> moment). It didn't seem worth it; but I can move those two includes from >> the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h >> >> Which do you prefer? > Actually ipu3-cio2.h misses a lot of inclusions (like mutex.h which I > immediately noticed when scrolled over data types). I think here should be a > compromise variant, split out something like ipu3-cio2-defs.h which can be > included in both ipu3-cio2.h and cio2-bridge.h.
And just including all the things that need to be in both files you mean?
> > And cio2-bridge.h needs more inclusions like types.h.
Added this in there too
| |