lkml.org 
[lkml]   [2021]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver
    On Sat, Jan 02, 2021 at 05:12:47PM +0000, Daniel Scally wrote:
    > Hi Sakari
    >
    > On 02/01/2021 17:07, Sakari Ailus wrote:
    > > Hi Daniel,
    > >
    > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote:
    > >>>>> +#define CIO2_NUM_PORTS 4
    > >>> This is already defined in ipu3-cio2.h. Could you include that instead?
    > >> Yes; but I'd need to also include media/v4l2-device.h and
    > >> media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the
    > >> moment). It didn't seem worth it; but I can move those two includes from
    > >> the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h
    > >>
    > >> Which do you prefer?
    > > Seems you got answers already... :-) splitting the header in two seems good
    > > to me. But IMO it doesn't have to be a part of this set.
    > >
    > Yeah I've been hesitating over this; if we chose not to do it in this
    > set though, how would you want me to deal with the double definition of
    > CIO2_NUM_PORTS

    How about prepending Andy's patch to the set and including the header?

    --
    Sakari Ailus

    \
     
     \ /
      Last update: 2021-01-02 18:25    [W:2.394 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site