lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.
On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
> Fixed a checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
> #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
> +/****************************************************************************
> +
>
> The code is full of comments like this. Should the coding style
> be inforced here, even when there is a logic to the way the code
> was broken up?
>
> Signed-off-by: Daniel West <daniel.west.dev@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> index 8794907a39f4..adf2788a416f 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> @@ -4591,11 +4591,10 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter)
> }
> }
>
> -/****************************************************************************
> -
> -Following are the functions for the timer handlers
> -
> -*****************************************************************************/
> +/*
> + *
> + *Following are the functions for the timer handlers
> + */

Does that look correct? Make it all one line please.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-12-28 15:35    [W:0.041 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site