lkml.org 
[lkml]   [2020]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.
    On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote:
    > Fixed a checkpatch warning:
    >
    > WARNING: Block comments use * on subsequent lines
    > #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595:
    > +/****************************************************************************
    > +
    >
    > The code is full of comments like this. Should the coding style
    > be inforced here, even when there is a logic to the way the code
    > was broken up?

    You should make one patch which atleast fix one file at ones. It would
    be even better if it fixes whole stuff (example one driver) right a way.
    Also note that you should not but this kind messages to your patch
    message. If you want to note this kind of thing you can use --- and
    after that it will not included in patch itself. You can read it online
    more.

    Also where does this [PATCH 8455/8455] even come from? Good thing is
    that you really didn't send so many patches or atleast I won't see them.

    And it seems that you are new so welcome a board :)

    --
    Kari Argillander

    \
     
     \ /
      Last update: 2020-12-20 16:31    [W:4.088 / U:0.872 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site