Messages in this thread Patch in this message | | | From | trix@redhat ... | Subject | [PATCH] amd-xgbe: remove h from printk format specifier | Date | Wed, 23 Dec 2020 11:43:45 -0800 |
| |
From: Tom Rix <trix@redhat.com>
This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c index 61f39a0e04f9..3c18f26bf2a5 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c @@ -339,14 +339,14 @@ static int xgbe_set_link_ksettings(struct net_device *netdev, speed = cmd->base.speed; if (cmd->base.phy_address != pdata->phy.address) { - netdev_err(netdev, "invalid phy address %hhu\n", + netdev_err(netdev, "invalid phy address %u\n", cmd->base.phy_address); return -EINVAL; } if ((cmd->base.autoneg != AUTONEG_ENABLE) && (cmd->base.autoneg != AUTONEG_DISABLE)) { - netdev_err(netdev, "unsupported autoneg %hhu\n", + netdev_err(netdev, "unsupported autoneg %u\n", cmd->base.autoneg); return -EINVAL; } @@ -358,7 +358,7 @@ static int xgbe_set_link_ksettings(struct net_device *netdev, } if (cmd->base.duplex != DUPLEX_FULL) { - netdev_err(netdev, "unsupported duplex %hhu\n", + netdev_err(netdev, "unsupported duplex %u\n", cmd->base.duplex); return -EINVAL; } -- 2.27.0
| |