Messages in this thread | | | Subject | Re: [PATCH v3 13/15] remoteproc: Properly deal with a start request when attached | From | Arnaud POULIQUEN <> | Date | Wed, 2 Dec 2020 19:14:45 +0100 |
| |
On 11/26/20 10:06 PM, Mathieu Poirier wrote: > This patch takes into account scenarios where a remote processor > has been attached to when receiving a "start" command from sysfs. > > As with the "running" case, the command can't be carried out if the > remote processor is already in operation. > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Thanks, Arnaud
> --- > drivers/remoteproc/remoteproc_cdev.c | 3 ++- > drivers/remoteproc/remoteproc_sysfs.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_cdev.c b/drivers/remoteproc/remoteproc_cdev.c > index d06f8d4919c7..61541bc7d26c 100644 > --- a/drivers/remoteproc/remoteproc_cdev.c > +++ b/drivers/remoteproc/remoteproc_cdev.c > @@ -32,7 +32,8 @@ static ssize_t rproc_cdev_write(struct file *filp, const char __user *buf, size_ > return -EFAULT; > > if (!strncmp(cmd, "start", len)) { > - if (rproc->state == RPROC_RUNNING) > + if (rproc->state == RPROC_RUNNING || > + rproc->state == RPROC_ATTACHED) > return -EBUSY; > > ret = rproc_boot(rproc); > diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c > index 3696f2ccc785..7d281cfe3e03 100644 > --- a/drivers/remoteproc/remoteproc_sysfs.c > +++ b/drivers/remoteproc/remoteproc_sysfs.c > @@ -194,7 +194,8 @@ static ssize_t state_store(struct device *dev, > int ret = 0; > > if (sysfs_streq(buf, "start")) { > - if (rproc->state == RPROC_RUNNING) > + if (rproc->state == RPROC_RUNNING || > + rproc->state == RPROC_ATTACHED) > return -EBUSY; > > ret = rproc_boot(rproc); >
| |