lkml.org 
[lkml]   [2020]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/3] thermal/core: Use precomputed jiffies for the polling
From
Date


On 12/16/20 5:03 PM, Daniel Lezcano wrote:
> The delays are also stored in jiffies based unit. Use them instead of
> the ms.
>
> Cc: Thara Gopinath <thara.gopinath@linaro.org>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
> drivers/thermal/thermal_core.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)

Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>

>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 2c41d4a0923f..d96c515af3cb 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -289,16 +289,11 @@ static int __init thermal_register_governors(void)
> * - Critical trip point will cause a system shutdown.
> */
> static void thermal_zone_device_set_polling(struct thermal_zone_device *tz,
> - int delay)
> + unsigned long delay)
> {
> - if (delay > 1000)
> + if (delay)
> mod_delayed_work(system_freezable_power_efficient_wq,
> - &tz->poll_queue,
> - round_jiffies(msecs_to_jiffies(delay)));
> - else if (delay)
> - mod_delayed_work(system_freezable_power_efficient_wq,
> - &tz->poll_queue,
> - msecs_to_jiffies(delay));
> + &tz->poll_queue, delay);
> else
> cancel_delayed_work(&tz->poll_queue);
> }
> @@ -317,9 +312,9 @@ static void monitor_thermal_zone(struct thermal_zone_device *tz)
> mutex_lock(&tz->lock);
>
> if (!stop && tz->passive)
> - thermal_zone_device_set_polling(tz, tz->passive_delay);
> + thermal_zone_device_set_polling(tz, tz->passive_delay_jiffies);
> else if (!stop && tz->polling_delay)
> - thermal_zone_device_set_polling(tz, tz->polling_delay);
> + thermal_zone_device_set_polling(tz, tz->polling_delay_jiffies);
> else
> thermal_zone_device_set_polling(tz, 0);
>
>

--
Warm Regards
Thara

\
 
 \ /
  Last update: 2020-12-18 16:09    [W:0.109 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site