Messages in this thread | | | Subject | Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB | From | Rafał Miłecki <> | Date | Mon, 14 Dec 2020 13:24:32 +0100 |
| |
On 11.12.2020 23:08, Florian Fainelli wrote: > On 12/11/20 1:59 PM, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). >> It's needed to power on and off SoC blocks like PCIe, SATA, USB. >> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > I will do a more thorough review tonight, however do you mind moving the > driver under drives/soc/bcm/bcm63xx? The first SoC that had PMB was > 63138 and that one is DSL.
I now realized that bcm63xx's: * Kconfig is wrapper in: if SOC_BCM63XX * Makefile is conditional: obj-$(CONFIG_SOC_BCM63XX)
So it means I've to either: 1. Refactor bcm63xx structure 2. Make SOC_BCM63XX selectable on ARCH_BCM4908 and select it
I'm not sure if any of above is a really good idea. Any further thought, ideas?
| |