Messages in this thread | | | Subject | Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB | From | Rafał Miłecki <> | Date | Mon, 14 Dec 2020 09:00:25 +0100 |
| |
On 12.12.2020 04:26, Florian Fainelli wrote: >> + >> +static const struct bcm_pmb_pd_data bcm_pmb_bcm4908_data[] = { >> + { .name = "pcie2", .id = BCM_PMB_PCIE2, .bus = 0, .device = 2, }, >> + { .name = "pcie0", .id = BCM_PMB_PCIE0, .bus = 1, .device = 14, }, >> + { .name = "pcie1", .id = BCM_PMB_PCIE1, .bus = 1, .device = 15, }, >> + { .name = "usb", .id = BCM_PMB_HOST_USB, .bus = 1, .device = 17, }, > > Do you have to be more specific and spell out whether this is the host > controller (xhci) or device (bdc)? If not, then this looks good to me.
I believe I have to and I believe I already do. I used BCM_PMB_HOST_USB which clearly (I believe) points to the HOST controller.
In 6838 part of pmc_drv.h from Broadcom's SDK I found:
enum { USB30_2X_Zone_Common, USB30_2X_Zone_USB_Host, USB30_2X_Zone_USB_Device, };
and that's what makes me believe we need to specify HOST explicitly.
| |