Messages in this thread Patch in this message | | | From | Alex Elder <> | Subject | [PATCH net-next] net: ipa: fix build-time bug in ipa_hardware_config_qsb() | Date | Tue, 1 Dec 2020 13:58:55 -0600 |
| |
Jon Hunter reported observing a build bug in the IPA driver: https://lore.kernel.org/netdev/5b5d9d40-94d5-5dad-b861-fd9bef8260e2@nvidia.com
The problem is that the QMB0 max read value set for IPA v4.5 (16) is too large to fit in the 4-bit field.
This is a quick fix to resolve the build bug; this might change again in the future if I learn there is a better value to use.
Reported-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Alex Elder <elder@linaro.org> --- drivers/net/ipa/ipa_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index f25bcfe51dd4b..192f9d6bccf19 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -280,7 +280,7 @@ static void ipa_hardware_config_qsb(struct ipa *ipa) max1 = 0; /* PCIe not present */ break; case IPA_VERSION_4_5: - max0 = 16; + max0 = 15; break; } val = u32_encode_bits(max0, GEN_QMB_0_MAX_READS_FMASK); -- 2.20.1
| |