lkml.org 
[lkml]   [2020]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment


On Fri, 6 Nov 2020, Sudip Mukherjee wrote:

> Hi Lukas,
>
> On 06/11/2020 10:31, Lukas Bulwahn wrote:
> >
> >
> > On Fri, 6 Nov 2020, Sudip Mukherjee wrote:
> >
> >> Hi Lukas,
> >>
>
> <snip>
>
> >
> > I did not try but I bet (a beverage of your choice) that the object code
> > remains the same also for your suggested patch. Try to disprove my claim
> > and possibly earn yourself a beverage when we meet...
>
> Lets decide which beverage.. ;-)
>
> Using gcc-7.2.0 for MIPS:
>
> original:- ab81d3305d578c2568fbc73aad2f9e61 kernel/taskstats.o
> After your change:- ab81d3305d578c2568fbc73aad2f9e61 kernel/taskstats.o
> After my change:- 0acae2c8d72abd3e15bf805fccdca711 kernel/taskstats.o
>
>

Interesting, can you share the diff of the objdump before and after?

I bet it found now a different assignment from variables to registers or
so; with the beverage at hand, we can then discuss if that is effectively
still the same object code or not.

Thanks for confirming that my patch here really remains the same compared
to before, even on MIPS :) I only checked x86-64...

Lukas

>
> --
> Regards
> Sudip
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#148): https://lists.elisa.tech/g/linux-safety/message/148
> Mute This Topic: https://lists.elisa.tech/mt/78069241/1714638
> Group Owner: linux-safety+owner@lists.elisa.tech
> Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [lukas.bulwahn@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
>

\
 
 \ /
  Last update: 2020-11-06 13:39    [W:0.064 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site