lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment
On Fri, Nov 06, 2020 at 12:04:53PM +0000, Sudip Mukherjee wrote:
> Hi Lukas,
>
> On 06/11/2020 10:31, Lukas Bulwahn wrote:
> >
> >
> > On Fri, 6 Nov 2020, Sudip Mukherjee wrote:
> >
> >> Hi Lukas,
> >>
>
> <snip>
>
> >
> > I did not try but I bet (a beverage of your choice) that the object code
> > remains the same also for your suggested patch. Try to disprove my claim
> > and possibly earn yourself a beverage when we meet...
>
> Lets decide which beverage.. ;-)
>
> Using gcc-7.2.0 for MIPS:
>
> original:- ab81d3305d578c2568fbc73aad2f9e61 kernel/taskstats.o
> After your change:- ab81d3305d578c2568fbc73aad2f9e61 kernel/taskstats.o
> After my change:- 0acae2c8d72abd3e15bf805fccdca711 kernel/taskstats.o

I'm surprised the line numbers from the printks aren't affecting it...

I personally prefer Lukas's patch. "rc" should be function scope...

regards,
dan carpenter

\
 
 \ /
  Last update: 2020-11-10 09:07    [W:0.180 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site