Messages in this thread | | | From | Ezequiel Garcia <> | Subject | [PATCH v2 0/3] MPEG-2 stateless API cleanup | Date | Thu, 5 Nov 2020 17:51:15 -0300 |
| |
Hello everyone,
Following the H.264 API cleanup, and with all the lessons learned from it, here's a revisit on the MPEG-2 API.
The biggest changes are:
* Drop slice size and offset parameters, given the API doesn't seem to be designed to work per-slice.
* Convert all the 1-bit syntax elements from structure fields to bits in a bit field flags field, following the other codec APIs.
* Split the sequence, picture and slice headers to separate controls.
This is build tested only, I haven't yet modified the existing Ffmpeg-based implementation, as I'd like to have some consensus first.
Reviews and feedback are appreciated!
v2:
* Fixed bad use of boolean negation in a flag, which was fortunately reported by 0day bot.
Thanks, Ezequiel
Ezequiel Garcia (3): media: uapi: mpeg2: Cleanup flags media: uapi: mpeg2: Remove unused slice size and offset media: uapi: mpeg2: Split sequence and picture parameters
.../media/v4l/ext-ctrls-codec.rst | 159 +++++++++++------- .../media/v4l/pixfmt-compressed.rst | 5 +- drivers/media/v4l2-core/v4l2-ctrls.c | 59 ++++--- drivers/staging/media/hantro/hantro_drv.c | 10 ++ .../media/hantro/hantro_g1_mpeg2_dec.c | 82 +++++---- .../media/hantro/rk3399_vpu_hw_mpeg2_dec.c | 82 +++++---- drivers/staging/media/sunxi/cedrus/cedrus.c | 14 ++ drivers/staging/media/sunxi/cedrus/cedrus.h | 2 + .../staging/media/sunxi/cedrus/cedrus_mpeg2.c | 49 +++--- include/media/mpeg2-ctrls.h | 153 +++++++++++++---- include/media/v4l2-ctrls.h | 4 + 11 files changed, 395 insertions(+), 224 deletions(-)
-- 2.27.0
| |