Messages in this thread | | | From | George Cherian <> | Subject | Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA | Date | Tue, 3 Nov 2020 17:59:19 +0000 |
| |
Hi Willem,
> -----Original Message----- > From: Willem de Bruijn <willemdebruijn.kernel@gmail.com> > Sent: Tuesday, November 3, 2020 11:26 PM > To: George Cherian <gcherian@marvell.com> > Cc: Network Development <netdev@vger.kernel.org>; linux-kernel <linux- > kernel@vger.kernel.org>; Jakub Kicinski <kuba@kernel.org>; David Miller > <davem@davemloft.net>; Sunil Kovvuri Goutham > <sgoutham@marvell.com>; Linu Cherian <lcherian@marvell.com>; > Geethasowjanya Akula <gakula@marvell.com>; masahiroy@kernel.org > Subject: Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health > reporters for NPA > > On Tue, Nov 3, 2020 at 12:43 PM George Cherian <gcherian@marvell.com> > wrote: > > > > Hi Willem, > > > > > > > -----Original Message----- > > > From: Willem de Bruijn <willemdebruijn.kernel@gmail.com> > > > Sent: Tuesday, November 3, 2020 7:21 PM > > > To: George Cherian <gcherian@marvell.com> > > > Cc: Network Development <netdev@vger.kernel.org>; linux-kernel > > > <linux- kernel@vger.kernel.org>; Jakub Kicinski <kuba@kernel.org>; > > > David Miller <davem@davemloft.net>; Sunil Kovvuri Goutham > > > <sgoutham@marvell.com>; Linu Cherian <lcherian@marvell.com>; > > > Geethasowjanya Akula <gakula@marvell.com>; masahiroy@kernel.org > > > Subject: [EXT] Re: [net-next PATCH 2/3] octeontx2-af: Add devlink > > > health reporters for NPA > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- > > > > > > static int rvu_devlink_info_get(struct devlink *devlink, > > > > > > struct > > > > > devlink_info_req *req, > > > > > > struct netlink_ext_ack > > > > > > *extack) { @@ > > > > > > -53,7 +483,8 @@ int rvu_register_dl(struct rvu *rvu) > > > > > > rvu_dl->dl = dl; > > > > > > rvu_dl->rvu = rvu; > > > > > > rvu->rvu_dl = rvu_dl; > > > > > > - return 0; > > > > > > + > > > > > > + return rvu_health_reporters_create(rvu); > > > > > > > > > > when would this be called with rvu->rvu_dl == NULL? > > > > > > > > During initialization. > > > > > > This is the only caller, and it is only reached if rvu_dl is non-zero. > > > > Did you mean to ask, where is it de-initialized? > > If so, it should be done in rvu_unregister_dl() after freeing rvu_dl. > > No, I meant that rvu_health_reporters_create does not need an !rvu- > >rvu_dl precondition test, as the only callers calls with with a non-zero > rvu_dl.
Yes understood!! Will fix in v2.
Thanks, -George
| |