lkml.org 
[lkml]   [2020]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver
On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote:
> > +static void sparx5_phylink_mac_config(struct phylink_config *config,
> > + unsigned int mode,
> > + const struct phylink_link_state *state)
> > +{
> > + struct sparx5_port *port = netdev_priv(to_net_dev(config->dev));
> > + struct sparx5_port_config conf;
> > + int err = 0;
> > +
> > + conf = port->conf;
> > + conf.autoneg = state->an_enabled;
> > + conf.pause = state->pause;
> > + conf.duplex = state->duplex;
> > + conf.power_down = false;
> > + conf.portmode = state->interface;
> > +
> > + if (state->speed == SPEED_UNKNOWN) {
> > + /* When a SFP is plugged in we use capabilities to
> > + * default to the highest supported speed
> > + */
>
> This looks suspicious.
>
> Russell, please could you look through this?

Maybe if I was copied on the patch submission... I don't have the
patches, and searching google for them is a faff, especially
when

site:kernel.org 20201127133307.2969817-1-steen.hegelund@microchip.com

gives:

Your search - site:kernel.org
20201127133307.2969817-1-steen.hegelund@microchip.com - did not
match any documents. Suggestions: Make sure that all words are
spelled correctly. Try different keywords. Try more general
keywords.

It seems that the modified MAINTAINERS entry is now annoyingly
missing stuff. I don't know what the solution is - either I get
irrelevant stuff or I don't get stuff I should.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

\
 
 \ /
  Last update: 2020-11-28 23:39    [W:0.655 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site