Messages in this thread | | | Date | Wed, 25 Nov 2020 07:25:29 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH 6/7] blk-iocost: Factor out the active iocgs' state check into a separate function |
| |
Hello,
On Tue, Nov 24, 2020 at 11:33:35AM +0800, Baolin Wang wrote: > -static void ioc_timer_fn(struct timer_list *timer) > +/* > + * Waiters determine the sleep durations based on the vrate they > + * saw at the time of sleep. If vrate has increased, some waiters > + * could be sleeping for too long. Wake up tardy waiters which > + * should have woken up in the last period and expire idle iocgs. > + */
Please reflow the comment.
... > + nr_debtors = ioc_check_iocg_state(ioc, &now);
How about ioc_check_iocgs()?
> + > commit_weights(ioc);
I think it'd make more sense to move commit_weights() inside the new function.
Thanks.
-- tejun
| |