Messages in this thread | | | Subject | Re: [PATCH 3/7] blk-iocost: Just open code the q_name() | From | Baolin Wang <> | Date | Wed, 25 Nov 2020 21:35:17 +0800 |
| |
> On Tue, Nov 24, 2020 at 11:33:32AM +0800, Baolin Wang wrote: >> The simple q_name() function is only called from ioc_name(), >> just open code it to make code more readable. >> >> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> > > I'm not sure this is an improvement. Either way seems fine to me. So, why > change?
Yes, this may be not called an 'improvement'. Just from my taste of reading code, there is no need to factor out a separate function only including 4 lines code and called by only one place. Anyway I can drop this patch if you think this is unnecessary. Thanks.
| |