Messages in this thread | | | From | "Ardelean, Alexandru" <> | Subject | RE: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() | Date | Sat, 21 Nov 2020 07:56:46 +0000 |
| |
> -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: Friday, November 20, 2020 5:46 PM > To: Ardelean, Alexandru <alexandru.Ardelean@analog.com> > Cc: linux-kernel@vger.kernel.org > Subject: Re: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() > > [External] > > On Thu, Nov 19, 2020 at 04:59:06PM +0200, Alexandru Ardelean wrote: > > The pci_get_drvdata() was moved during commit ef84928cff58 > > ("uio/uio_pci_generic: use device-managed function equivalents"). > > > > I should have notice that the pci_set_drvdata() requires a > > pci_get_drvdata() for it to make sense. > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > > --- > > > > Apologies for not noticing this sooner. > > If this can be squashed into commit ef84928cff58 , then it's also fine. > > I've started seeing that there actually more xxx_set_drvdata() > > leftovers in the entire kernel, and I pinged the checkpatch crew to > > add a check for this. > > > > https://urldefense.com/v3/__https://lore.kernel.org/lkml/CA*U=Dspy5*RE > > > 9agcLr6eY9DCMa1c5**B0JLeugMMBRXz4YLj1w@mail.gmail.com/T/*u__;KysrK > ysj! > > > !A3Ni8CS0y2Y!q3fJW4rKvEHQ7BDt1PaK4Cbexv4wbivUKBeDjo7ZwNXYwOLBawA > Eq1Jaj > > mhYxftX6DAJpg$ > > I can't squash existing public commits. Can you resend this and add a "Fixes:" > tag to it to show what commit it fixes so we can track this properly? >
Sure, will re-send in the next couple of days.
Thanks Alex
> thanks, > > greg k-h
| |