Messages in this thread | | | Date | Fri, 20 Nov 2020 16:46:07 +0100 | From | Greg KH <> | Subject | Re: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() |
| |
On Thu, Nov 19, 2020 at 04:59:06PM +0200, Alexandru Ardelean wrote: > The pci_get_drvdata() was moved during commit ef84928cff58 > ("uio/uio_pci_generic: use device-managed function equivalents"). > > I should have notice that the pci_set_drvdata() requires a > pci_get_drvdata() for it to make sense. > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > --- > > Apologies for not noticing this sooner. > If this can be squashed into commit ef84928cff58 , then it's also fine. > I've started seeing that there actually more xxx_set_drvdata() leftovers > in the entire kernel, and I pinged the checkpatch crew to add a check > for this. > > https://lore.kernel.org/lkml/CA+U=Dspy5+RE9agcLr6eY9DCMa1c5+++0JLeugMMBRXz4YLj1w@mail.gmail.com/T/#u
I can't squash existing public commits. Can you resend this and add a "Fixes:" tag to it to show what commit it fixes so we can track this properly?
thanks,
greg k-h
| |