Messages in this thread | | | Date | Mon, 2 Nov 2020 09:52:20 -0500 | From | Johannes Weiner <> | Subject | Re: [PATCH v20 12/20] mm/vmscan: remove lruvec reget in move_pages_to_lru |
| |
On Thu, Oct 29, 2020 at 06:44:57PM +0800, Alex Shi wrote: > A isolated page shouldn't be recharged by memcg since the memcg > migration isn't possible at the time. > So remove unnecessary regetting. > > Thanks to Alexander Duyck for pointing this out. > > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com> > Acked-by: Hugh Dickins <hughd@google.com> > Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Hugh Dickins <hughd@google.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
A brief comment in the code could be good: all pages were isolated from the same lruvec (and isolation inhibits memcg migration).
| |