Messages in this thread | | | Date | Fri, 30 Oct 2020 09:52:18 -0400 | From | Johannes Weiner <> | Subject | Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail |
| |
On Fri, Oct 30, 2020 at 10:46:54AM +0800, Alex Shi wrote: > 在 2020/10/29 下午9:50, Johannes Weiner 写道: > > It may be better to pick either > > head and tail > > Hi Johannes, > > Thanks for comments! > > Right, Consider functions in this file are using head/tail more as parameters > I will change to use head/tail too. And then, the 04th, 05th, and 18th patch > will be changed accordingly.
That's great, thank you!
> From a9ee63a213f40eb4d5a69b52fbb348ff9cd7cf6c Mon Sep 17 00:00:00 2001 > From: Alex Shi <alex.shi@linux.alibaba.com> > Date: Tue, 26 May 2020 16:49:22 +0800 > Subject: [PATCH v21 04/20] mm/thp: use head for head page in lru_add_page_tail > > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com> > Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Acked-by: Hugh Dickins <hughd@google.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Hugh Dickins <hughd@google.com> > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |